[DCJ-621][risk=no] Small fixes for documentation issues found during onboarding. #2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….0), and adjusts the comment in the css to clear the error in building the app.
otchet-broad
requested review from
rushtong and
fboulnois
and removed request for
a team
rushtong
approved these changes
Aug 19, 2024
|
|
||
| ``` | ||
| curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh | bash | ||
| nvm install 16 | ||
| nvm install 22.6.0 |
There was a problem hiding this comment.
I'd love it if we could tie this to what's defined in Dockerfile, but that's definitely out of scope here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DCJ-621
Summary
Two small items needed to be addressed while onboarding: node version instructions and a comment in CSS.
#character. This leads to an error in the source map loader. I've updated the comment and removed the offending character so that the comment remains and the source map loader works properly and stops complaining about it.Have you read Terra's Contributing Guide lately? If not, do that first.